Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Tracking #249

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Release Tracking #249

merged 1 commit into from
Feb 20, 2025

Conversation

openprojectci
Copy link

@openprojectci openprojectci commented Feb 20, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@openproject/[email protected]

Patch Changes

  • #246 26fdce6 Thanks @myabc! - DangerDialog now uses the "alertdialog" ARIA role

  • #245 27b6af1 Thanks @myabc! - Fix broken FeedbackDialog aria-describedby value - was referencing non-existent id.

  • #243 79986c4 Thanks @myabc! - Fix DangerDialog body scroll behaviour when containing a form: the dialog's confirm and cancel buttons should now always be visible in the viewport, never scrolling with the other dialog content.

  • #245 27b6af1 Thanks @myabc! - Fix broken DangerDialog aria-describedby value - was referencing non-existent id.

Copy link

❗ Pre-merge checklist

Please ensure these items are checked before merging.

🔎 Smoke test

  • All CI checks pass
  • Lookbook opens in a browser
  • Successful integration test with OpenProject as a primary consumer
    • Install the npm package locally
    • Install the primer_view_components gem locally
    • Verify no new build errors appear
    • Verify no new linting errors appear
    • Manually test critical paths
    • Manually test release-specific bugfixes and/or features work as described

🤔 Sanity test

  • All bugfixes in this release have resolved their corresponding issues
  • All new features in this release have been tested and verified as compatible with OpenProject
  • No noticeable regressions have been introduced as a result of changes in this release
  • Release notes accurately describe the changes made

🚢 Post ship reminders

  • Deploy lookbook via chat ops in the #primer-rails-ops channel. .deploy primer-lookbook to production

Please also leave any testing notes as a comment on this pull request. In particular, describing any issues encountered during your testing. This is helpful in providing historical context to maintainers.

@HDinger HDinger merged commit dc3ddc2 into main Feb 20, 2025
35 checks passed
@HDinger HDinger deleted the changeset-release/main branch February 20, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants