Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ActionMenu as sidepanel section action #252

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

oliverguenther
Copy link
Member

https://community.openproject.org/work_packages/61788

What are you trying to accomplish?

Allow ActionMenu as sidepanel section action

Screenshots

Bildschirmfoto 2025-02-26 um 11 11 06

Risk Assessment

  • Low risk the change is small, highly observable, and easily rolled back.
  • Medium risk changes that are isolated, reduced in scope or could impact few users. The change will not impact library availability.
  • High risk changes are those that could impact customers and SLOs, low or no test coverage, low observability, or slow to rollback.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Lookbook)
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 97122bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@openproject/primer-view-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@oliverguenther oliverguenther force-pushed the feat/section-with-action-menu branch from a4dc47c to 97122bf Compare February 26, 2025 10:19
Copy link
Collaborator

@HDinger HDinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@oliverguenther oliverguenther merged commit b8822ba into main Feb 26, 2025
33 checks passed
@oliverguenther oliverguenther deleted the feat/section-with-action-menu branch February 26, 2025 10:38
@openprojectci openprojectci mentioned this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants