Refactor use pydantic for writing #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hellgartner
commented
Jan 13, 2025
Hellgartner
commented
- In ScanCode parsing and conversion #50 Pydatic was introduced
- In order to allow for parallel development, this PR attempts to extract that from the branch associated to the issue to get it to master faster
* fix broken test (cherry picked from commit f06643d)
|
LGTM |
abraemer
approved these changes
Jan 13, 2025
* add required dependency
Hellgartner
force-pushed
the
refactor-use-pydantic-for-writing
branch
from
82a43ac to
6bf54a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.