Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Add hot-fix to store issue for inherited attribute #116

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Bug: Add hot-fix to store issue for inherited attribute #116

merged 4 commits into from
Sep 9, 2024

Conversation

BeArchiTek
Copy link
Contributor

@BeArchiTek BeArchiTek commented Sep 6, 2024 •
edited
Loading

  • Fix issue when requesting attribute inherited from a generic into the inventory
  • Respect the validate_certs keywork

@BeArchiTek BeArchiTek added the type/bug Something isn't working label Sep 6, 2024
@BeArchiTek BeArchiTek self-assigned this Sep 6, 2024
@BeArchiTek BeArchiTek added the changes/patch Maintenance tasks label Sep 6, 2024
@BeArchiTek BeArchiTek requested a review from a team September 6, 2024 20:09
wvandeun
wvandeun approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@wvandeun wvandeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeArchiTek BeArchiTek merged commit 297187e into develop Sep 9, 2024
10 checks passed
@BeArchiTek BeArchiTek deleted the bkr-hotfix-issue-sdk-store branch November 4, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvandeun wvandeun wvandeun approved these changes

Assignees

@BeArchiTek BeArchiTek

Labels
changes/patch Maintenance tasks type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeArchiTek @wvandeun