Refactor structure of the project #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup and refactoring
Add data files, custom docker image and integration tests
BaptisteGi
reviewed
Apr 23, 2025
| @@ -0,0 +1,8 @@ | |||
| --- | |||
There was a problem hiding this comment.
Adding the repository like this isn't consistent with what's in the readme file I believe
BaptisteGi
reviewed
Apr 23, 2025
There was a problem hiding this comment.
Shouldn't we get rid of that one now that we use yaml objects?
There was a problem hiding this comment.
Will do in a future PR
BaptisteGi
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR regroup multiple changes and refactoring of the structure of the projects.
One of my goal is to help us come up with best practices on how to best organized a repository/project meant to work with Infrahub.
Main changes
infrahubctl objectcommand infrahub-sdk-python#328Dockerfileand docker compose to leverage local Python module within infrahub