-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsyncTyper class to the Python SDK #2453
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e222fe2
Disable PLR2004 in ruff
dgarros f8a8720
Add AsyncTyper class
dgarros c17ac12
Replace Typer with Async Typer when we are using Async in command
dgarros c63a04a
Fix order of imports
dgarros 7b53ed5
Update infrahubctl docs to remove schema migrate
dgarros File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
from __future__ import annotations | ||
|
||
import asyncio | ||
import inspect | ||
from functools import partial, wraps | ||
from typing import Any, Callable | ||
|
||
from typer import Typer | ||
|
||
|
||
class AsyncTyper(Typer): | ||
@staticmethod | ||
def maybe_run_async(decorator: Callable, func: Callable) -> Any: | ||
if inspect.iscoroutinefunction(func): | ||
|
||
@wraps(func) | ||
def runner(*args: Any, **kwargs: Any) -> Any: | ||
return asyncio.run(func(*args, **kwargs)) | ||
|
||
decorator(runner) | ||
else: | ||
decorator(func) | ||
return func | ||
|
||
def callback(self, *args: Any, **kwargs: Any) -> Any: | ||
decorator = super().callback(*args, **kwargs) | ||
return partial(self.maybe_run_async, decorator) | ||
|
||
def command(self, *args: Any, **kwargs: Any) -> Any: | ||
decorator = super().command(*args, **kwargs) | ||
return partial(self.maybe_run_async, decorator) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why we don't want to have this under infrahub_sdk.ctl instead? Is the intention that the server components would also load the same class from this location?. To me it feels cleaner to have it under .ctl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal is to have it available for other cli tools not just infrahubctl