Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling for irresolvable conflicts #4939

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ajtmccarty
Copy link
Contributor

add the ability to mark certain diff conflicts as irresolvable. right now, this is all node-level delete conflicts. for example, if I delete a node on main and update it on branch, we will block merging until the conflict is resolved manually, either by deleting the node on branch or undoing the changes on branch

also makes some changes to DiffCombiner b/c it was not correctly handling a manual undo of a conflict in some cases

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #4939 will not alter performance

Comparing ajtm-11142024-irresolvable-conflicts (39530fc) with develop (f00a6ae)

Summary

✅ 10 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant