add handling for irresolvable conflicts #4939
Draft
+444
−167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the ability to mark certain diff conflicts as irresolvable. right now, this is all node-level delete conflicts. for example, if I delete a node on
main
and update it onbranch
, we will block merging until the conflict is resolved manually, either by deleting the node onbranch
or undoing the changes onbranch
also makes some changes to DiffCombiner b/c it was not correctly handling a manual undo of a conflict in some cases