Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate GitRepositoriesImportObjects to prefect #4945

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasG0
Copy link
Contributor

@LucasG0 LucasG0 commented Nov 15, 2024

No description provided.

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Nov 15, 2024
Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #4945 will improve performances by 25.06%

Comparing lgu-migrate-git-repo-import (69c1b4e) with develop (0deba15)

Summary

⚡ 1 improvements
✅ 9 untouched benchmarks

Benchmarks breakdown

Benchmark develop lgu-migrate-git-repo-import Change
test_schemabranch_duplicate 390.8 µs 312.5 µs +25.06%

@github-actions github-actions bot added the type/documentation Improvements or additions to documentation label Nov 15, 2024
repository_id=repository_id,
repository_name=str(repo.name.value),
repository_kind=repo.get_kind(),
commit=str(repo.commit.value),
infrahub_branch_name=branch.name,
)
if context.service:
await context.service.send(message=message)
await context.service.workflow.submit_workflow(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to return the task id for this mutation moving forward.
i'll be useful to provide a better experience in the frontend as well at some point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent) type/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants