Skip to content

fix: 修复custom的异常输出 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2025
Merged

fix: 修复custom的异常输出 #30

merged 4 commits into from
Jun 18, 2025

Conversation

eryajf
Copy link
Member

@eryajf eryajf commented Jun 18, 2025

未做空配置判断,导致有异常输出。

#29

Summary by CodeRabbit

  • 文档

    • 在文档中新增对“自定义记录”DNS服务商的支持说明,并将其添加到支持列表中。
  • 优化

    • 优化自定义记录证书信息指标的收集逻辑,仅在存在自定义记录时才进行相关操作。

@eryajf eryajf added the bug Something isn't working label Jun 18, 2025
Copy link

coderabbitai bot commented Jun 18, 2025

"""

Walkthrough

本次变更在文档中新增了“Custom Records”作为受支持的 DNS 服务商条目,并在代码中为自定义记录的证书信息指标采集增加了条件判断,仅在有自定义记录时才进行相关操作,遇错时提前返回。

Changes

文件/分组 变更摘要
README-en.md, README.md 在受支持的 DNS 服务商列表顶部新增“Custom Records”条目,并标记为已支持。
pkg/export/export_gauge.go 增加条件判断,仅在 CustomRecords 非空时才采集相关证书信息指标,遇错误时提前返回。

Poem

兔子挥笔写新篇,
DNS 伙伴添一员。
Custom Records 上榜前,
代码守门更周全。
跳跃更新乐无边,
指标采集更省电! 🐇✨
"""


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a922cba and ee8caa4.

📒 Files selected for processing (1)
  • pkg/export/export_gauge.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pkg/export/export_gauge.go
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
pkg/export/export_gauge.go (1)

164-165: 条件判断粒度 OK,但可读性小改进

len(public.Config.CustomRecords) != 0 能够精准过滤空配置;
通常 Go 社区更偏好 “早返回” 写法,可将整个块抽成私有函数 c.collectCustomCerts(),主流程更加清晰。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2056f12 and a922cba.

📒 Files selected for processing (3)
  • README-en.md (1 hunks)
  • README.md (1 hunks)
  • pkg/export/export_gauge.go (1 hunks)
🔇 Additional comments (2)
README.md (1)

136-136: 文档同步 👍

已将 “Custom Records” 标注为已支持,保持与代码实现一致。

README-en.md (1)

134-134: Docs updated consistently

英文文档亦同步新增 “Custom Records”,保持多语言一致性。

@eryajf eryajf merged commit 3311757 into main Jun 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant