Skip to content

Add corelens plugin to sosreport #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

apalakun
Copy link
Member

Orabug: Jira-LSE-524
Add corelens plugin to sosreport

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 26, 2025
Orabug: Jira-LSE-524
Signed-off-by: Anil Lal <[email protected]>
@brenns10
Copy link
Member

Hi Anil, sorry for the delay in reviewing & testing. I'm aiming to get through the drgn-tools backlog here, and I've gone ahead and looked through this PR. I identified a few issues.

  1. The changelog entries in the spec file shouldn't be added - I'll do those, and credit each developer, when I trigger releases. This is where your merge conflicts came from.
  2. The sosreport plugin script uses CRLF line endings, but everything on Linux should use LF line endings. I'm not sure how that happened.
  3. There were some issues in my pre-commit configuration, and the result was that the code formatter (black) did not run.
  4. There's no reason to call rpm to check the corelens version -- since this plugin is provided by the drgn-tools RPM, we can assume it is a suitable version.
  5. The spec files code for installation had a few issues which were easily corrected.

I made the changes (and rebased onto the latest) in this branch, so I could go ahead and test:
https://github.com/brenns10/drgn-tools/tree/anil_sosreport

I built an OL9 RPM and installed it, and then tested the core functionality with sos report --batch and checked that the corelens results for vmcores were present. It's really cool!

If you'd like to incorporate the fixes I made, we can go that route. Or I can create a new PR and you can review that directly, and we can close this one. Let me know what you'd like.

@brenns10
Copy link
Member

Closing based on the above, I'll open a new PR and request your review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants