[2.1.x] Backports of recent fixes for build #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orabug: 37911511 Signed-off-by: Stephen Brennan <[email protected]>
Signed-off-by: Stephen Brennan <[email protected]>
Reported-by: John Sobecki <[email protected]> Signed-off-by: Stephen Brennan <[email protected]>
The arguments here were causing black to not output any changes, and so pre-commit wasn't enforcing coding style. This actually explains quite a bit. Signed-off-by: Stephen Brennan <[email protected]>
The lack of pre-commit and black code formatting resulted in some issues slipping through. Run pre-commit to fix them. Signed-off-by: Stephen Brennan <[email protected]>
The urllib.HTTPError exception, in addition to printing a quite large stack trace, omits the URL. This is probably a good thing for security, but here we don't care because we're fetching public URLs anyway. So catch the exception, print a formatted error message, and then use sys.exit to avoid a traceback. This way, the CI errors will actually let us know which RPM is missing. I mean, it's always the kernel-ueknext-debuginfo. It's never not that. But still, I want the CI to tell me that rather than forcing me to guess. Signed-off-by: Stephen Brennan <[email protected]>
Signed-off-by: Stephen Brennan <[email protected]>
When a new kernel-ueknext is released, it is not uncommon that the debuginfo is either forgotten, or delayed. It's fine to have this happen: I will report it and ensure we upload our debuginfo. I'd rather I encounter this than a customer. However, in the meantime, this means that drgn-tools PRs cannot be merged. This isn't a great situation. So, allow the CI latest version detection to skip the most recent version if an RPM is missing. Signed-off-by: Stephen Brennan <[email protected]>
Orabug: 37973187 Signed-off-by: Stephen Brennan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
biger410
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orabug: 37911511
Orabug: 37973190
Backporting the fixes from #160 and #163 into the 2.1.x branch to ensure CI passes.