-
Notifications
You must be signed in to change notification settings - Fork 21
debuginfo: Find vmlinux at other locations #166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
Hi @Asphaltt, I'm actually gearing up to completely revamp this section of drgn-tools. Since drgn 0.0.31, drgn's Module API does a really great job of finding debug info -- and especially, allowing the user to customize the process. So in my development branch, we're dropping most of the code that searches the "standard directories" for debuginfo, and just relying on drgn to do that. We'll provide some extra logic for some things that may be a bit more specific to Oracle Linux, but lookups in the standard paths will use drgn's standard logic, and thus should work well on any distro without modification. I'm also really curious, are there any specific helpers or tools you're using out of drgn-tools? I didn't know anybody outside Oracle was using it, and if there are rough edges I can help smooth out (including the debuginfo, which I'll do my best to get the changes out quickly), I would be glad to help. |
That said, the changes here look very reasonable, so I wouldn't have any problem including them before those changes I mentioned land. |
Thanks for these great drgn tools — honestly, they're the best alternatives to
That’s great to hear. I'm looking forward to seeing the improvements!
Not yet. When I first explored these tools on Ubuntu, I ran into an issue: $ sudo corelens /proc/kcore -M sys
warning: Running corelens against a live system.
Data may be inconsistent, or corelens may crash.
error: could not find debuginfo (tried DWARF) I had to fix that first before I could start using them properly. And with that, here’s the PR. |
Thank you for signing the OCA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With pre-commit fixes, this looks good to me.
On some distributions (e.g., Ubuntu), vmlinux may not reside in the modules directory. Search common locations for vmlinux, as referenced in: https://github.com/anakryiko/retsnoop/blob/389e2c9ddfc686ee048b063ce0c17b94b55398d2/src/retsnoop.c#L59-L67 Signed-off-by: Leon Hwang <[email protected]>
9f31800
to
c68f1e1
Compare
Thank you! If you'd like, I can mention you on the PR for the broader changes to debuginfo loading, so you can have a look yourself. |
Seems cool. Thank you! |
On some distributions (e.g., Ubuntu), vmlinux may not reside in the modules directory. Search common locations for vmlinux, as referenced in: https://github.com/anakryiko/retsnoop/blob/389e2c9ddfc686ee048b063ce0c17b94b55398d2/src/retsnoop.c#L59-L67