Skip to content

Memstate Module #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Memstate Module #170

merged 2 commits into from
Jun 24, 2025

Conversation

YassineLr
Copy link
Member

integrating memstate module into CoreLens.

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

  • PR author: YassineLr

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Jun 11, 2025
@YassineLr YassineLr force-pushed the dev/oled-memstate branch from 5de6649 to 4303de1 Compare June 11, 2025 18:21
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Jun 11, 2025
Copy link
Member

@brenns10 brenns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a quick review. In addition to the comments on the code below, here are a few quick and easy fixes.

(1) Use git commit -s (sign-off) for your commits, so they include your "Signed-off-by" tag. See prior commits in history for examples.
(2) Check the following pre-commit findings:


drgn_tools/memstate.py:111:25: E221 multiple spaces before operator
drgn_tools/memstate.py:365:27: E226 missing whitespace around arithmetic operator
drgn_tools/memstate.py:365:33: E225 missing whitespace around operator
drgn_tools/memstate.py:365:45: E225 missing whitespace around operator
drgn_tools/memstate.py:383:31: E226 missing whitespace around arithmetic operator
drgn_tools/memstate.py:383:37: E225 missing whitespace around operator
drgn_tools/memstate.py:383:49: E225 missing whitespace around operator
drgn_tools/memstate.py:499:25: E231 missing whitespace after ','
drgn_tools/memstate.py:503:62: E231 missing whitespace after ','

CoreLens equivalent of memstate: this module provides analysis of various memory usage statistics, including both userspace and kernel memory.

Signed-off-by: Yassine Larhrissi <[email protected]>
@YassineLr YassineLr force-pushed the dev/oled-memstate branch from f665eaa to 6447987 Compare June 21, 2025 12:36
@brenns10
Copy link
Member

This looks really great! Thank you!

@brenns10 brenns10 merged commit 882d2d0 into oracle-samples:main Jun 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants