-
Notifications
You must be signed in to change notification settings - Fork 21
Memstate Module #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memstate Module #170
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
5de6649
to
4303de1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a quick review. In addition to the comments on the code below, here are a few quick and easy fixes.
(1) Use git commit -s
(sign-off) for your commits, so they include your "Signed-off-by" tag. See prior commits in history for examples.
(2) Check the following pre-commit findings:
drgn_tools/memstate.py:111:25: E221 multiple spaces before operator
drgn_tools/memstate.py:365:27: E226 missing whitespace around arithmetic operator
drgn_tools/memstate.py:365:33: E225 missing whitespace around operator
drgn_tools/memstate.py:365:45: E225 missing whitespace around operator
drgn_tools/memstate.py:383:31: E226 missing whitespace around arithmetic operator
drgn_tools/memstate.py:383:37: E225 missing whitespace around operator
drgn_tools/memstate.py:383:49: E225 missing whitespace around operator
drgn_tools/memstate.py:499:25: E231 missing whitespace after ','
drgn_tools/memstate.py:503:62: E231 missing whitespace after ','
CoreLens equivalent of memstate: this module provides analysis of various memory usage statistics, including both userspace and kernel memory. Signed-off-by: Yassine Larhrissi <[email protected]>
f665eaa
to
6447987
Compare
This looks really great! Thank you! |
integrating memstate module into CoreLens.