Small fixes #186
Merged
Small fixes #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux only requires that filenames cannot contain the byte '/' or the NUL byte. They do not have any specific encoding and aren't even guaranteed to be text. Thus, using bytes.decode() is not reliable. Use escape_ascii_string() when handling dentry names and paths. Signed-off-by: Stephen Brennan <[email protected]>
Signed-off-by: Stephen Brennan <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
It was removed and defaulted to zero in 6.16. This allows us existing code to continue working with compatibility for old kernels. The "Bounce" field in meminfo will likely remain hard-coded to zero for a long time anyway. Signed-off-by: Stephen Brennan <[email protected]>
brenns10
force-pushed
the
fix_dentry_decode
branch
from
d5d384b to
27914a3
Compare
biger410
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three small fixes here. Two relate to string encoding and decoding. We've sometimes done a bit of unnecessary (or even harmful)
str.decode()operations. Many kinds of data in the kernel (filenames, printk buffer) don't have guaranteed encodings, so decoding with the utf-8 encoding is not the right call. The right way is either to keep the data inbytesif possible, or else useescape_ascii_string()if we expect it to be text and we want to include it in text-mode/string output.The last fix is for a change in 6.16 that has broken the test framework.