Skip to content

feat: add example deployment scripts#7

Merged
AlaaShaker merged 4 commits intooracle-samples:mainfrom
gebhardtr:rigebha/infra
Jan 9, 2026
Merged

feat: add example deployment scripts#7
AlaaShaker merged 4 commits intooracle-samples:mainfrom
gebhardtr:rigebha/infra

Conversation

@gebhardtr
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Dec 18, 2025
@gebhardtr gebhardtr marked this pull request as ready for review December 18, 2025 19:18
Signed-off-by: Richard Gebhardt <[email protected]>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we put this in a variable?


ingress_security_rules {
protocol = "6" # TCP
source = "0.0.0.0/0"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the source of this be the ollama server's specific ip address rather than public?

Copy link
Member Author

@gebhardtr gebhardtr Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this allows connections from any IP; in practice, we limit this to specific IPs/blocks. I'll make this a variable in a subsequent PR after I figure out a good way to do it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a variable?

Signed-off-by: Richard Gebhardt <[email protected]>
@AlaaShaker AlaaShaker merged commit 079e675 into oracle-samples:main Jan 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments