Add compatability for py 3.12 (+Operators changes from 2.13.9rc0) #1171
Conversation
ahosler
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
|
|
📌 Cov diff with main: 📌 Overall coverage: |
| # [tool.flit.sdist] section of pyproject.toml. See: https://flit.pypa.io/en/latest/pyproject_toml.html#sdist-section | ||
| # If build-system library will change, make changed to list of included/excluded to build files accordingly | ||
| # as it will be suggested by new build-system library. | ||
| include THIRD_PARTY_LICENSES.txt |
There was a problem hiding this comment.
If we add MANIFEST back, we should consider to exclude the tests?
| "flit-core >=3.8,<4", | ||
| ] # should specify <4, so won’t be impacted by changes in the next major version | ||
| build-backend = "flit_core.buildapi" | ||
| requires = ["setuptools>=65", "wheel"] |
There was a problem hiding this comment.
Liuda transitioned the ADS project from setuptools to flit-core, likely for good reasons. If we consider reverting to setuptools, we must be cautious and ensure that the MANIFEST.in file includes all required non-Python resources. Unlike flit-core, which automatically includes all files within the package directory in the wheel, setuptools requires explicit specification of non-code files in MANIFEST.in and the package_data parameter in setup.py. Failing to do so may result in missing files in the built package.
|
|
📌 Cov diff with main: 📌 Overall coverage: |
No description provided.