Skip to content

Conversation

@alcampag
Copy link
Member

@alcampag alcampag commented Jan 9, 2026

  • Replace simple string check for ARM shapes with regex pattern Standard\.A\d+ for more accurate detection of A-series (ARM) shapes
  • Initialize NodeSourceViaImage if nil to prevent potential nil pointer dereference errors
  • Update test cases to use realistic ARM shape name "VM.Standard.A1.Flex" instead of placeholder
  • This improves reliability and accuracy in OCI managed machine pool node pool creation

Here the template used to verify the nil pointer exception cluster-test-native.yml

Checklist

  • All unit tests are passing
  • All PRBlocking tests are passing
  • Code builds successfully

- Replace simple string check for ARM shapes with regex pattern `Standard\.A\d+` for more accurate detection of A-series (ARM) shapes
- Initialize NodeSourceViaImage if nil to prevent potential nil pointer dereference errors
- Update test cases to use realistic ARM shape name "VM.Standard.A1.Flex" instead of placeholder
- This improves reliability and accuracy in OCI managed machine pool node pool creation
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 9, 2026
@joekr joekr self-requested a review January 9, 2026 15:25
@joekr joekr added the bug Something isn't working label Jan 9, 2026
@alcampag alcampag requested a review from joekr January 9, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants