Use a ClassLoader for locating resources #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the VirtualFileSystem was using a
Classas a beacon to find resources. I suppose that the intent was to useClass#getResource, but in practice, it's alwaysclazz.getClassLoader().getResource()which is used, which makes it redundant to use a class. This commit refactors the code to allow declaring which classloader to use for loading. This is important because in some cases, we don't necessarily have aClassto pass, but we do have a classloader. This should also allow more advanced scenarios with filtering classloaders for example.Since the
Classwas actually never directly used, but only its classloader, this change should have 0 impact for backwards compatibility.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: