feat: add github actions for macaron #1241
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
behnazh-w
changed the title
behnazh-w
changed the title
Signed-off-by: Demolus13 <[email protected]>
Signed-off-by: Demolus13 <[email protected]>
Signed-off-by: Demolus13 <[email protected]>
…from source. Signed-off-by: Demolus13 <[email protected]>
Signed-off-by: Demolus13 <[email protected]>
Demolus13
force-pushed
the
pgovale/github-action
branch
from
1180735 to
ce8d442
Compare
Signed-off-by: Demolus13 <[email protected]>
Demolus13
force-pushed
the
pgovale/github-action
branch
from
39ba4f5 to
5f341ab
Compare
…_github_actions.yaml Signed-off-by: Demolus13 <[email protected]>
Signed-off-by: Demolus13 <[email protected]>
behnazh-w
reviewed
Nov 30, 2025
| name: Detecting malicious packages | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Member
There was a problem hiding this comment.
Please pin all of the third-party Actions to the hash and add the version string as a comment. See how we do this in the rest of workflows:
macaron/.github/workflows/_build.yaml
Line 55 in 8791027
behnazh-w
reviewed
Nov 30, 2025
action.yaml
Outdated
| description: The path to the defaults configuration file. | ||
| digest: | ||
| description: The digest of the commit we want to checkout in the branch. | ||
| provenanace_expectation: |
Member
There was a problem hiding this comment.
Suggested change
| provenanace_expectation: | |
| provenance_expectation: |
action.yaml
Outdated
| description: The digest of the commit we want to checkout in the branch. | ||
| provenanace_expectation: | ||
| description: The path to provenance expectation file or directory. | ||
| provenanace_file: |
Member
There was a problem hiding this comment.
Suggested change
| provenanace_file: | |
| provenance_file: |
Signed-off-by: Demolus13 <[email protected]>
Signed-off-by: Demolus13 <[email protected]>
behnazh-w
reviewed
Nov 30, 2025
| output_dir: macaron_output/detect_malicious_package | ||
|
|
||
| - name: Setup Python for analyzed venv | ||
| uses: actions/setup-python@v6 |
Member
There was a problem hiding this comment.
Please pin this action to the hash that we use in other parts of Macaron. This comment applies to all the actions used in this workflow, please check.
behnazh-w
reviewed
Nov 30, 2025
Member
behnazh-w
left a comment
behnazh-w
left a comment
There was a problem hiding this comment.
How about renaming tests/tutorials to tests/tutorial_resources because we also have integration tests for each tutorial tagged with tutorial. We could add a README.md to tests/tutorial_resources to explain this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of changes
Related issues
Checklist
verifiedlabel should appear next to all of your commits on GitHub.