feat: add dockerfile output for Python builds #1242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
AbhinavPradeep
commented
Nov 24, 2025
Comment on lines
251
to
262
| # Now to get the latest acceptable one, we can step through all interpreter | ||
| # versions. For the most accurate result, we can query python.org for a | ||
| # list of all versions, but for now we can approximate by stepping down | ||
| # through every minor version from 3.14.0 to 3.0.0 | ||
| for minor in range(14, -1, -1): | ||
| try: | ||
| if Version(f"3.{minor}.0") in version_set: | ||
| return f"3.{minor}.0" | ||
| except InvalidVersion as error: | ||
| logger.debug("Ran into issue converting %s to a version: %s", minor, error) | ||
| return None | ||
| return None |
Contributor
Author
There was a problem hiding this comment.
I was wondering if this bit might be worth changing as per the code comment. The current way of finding the latest satisfying version is not fine-grained. It might fail on certain constraints as well, for example if we were given the constraint ["==3.11.5"]. It also does not fully use our ability to support arbitrarily specific interpreter versions via rebuilding them. So should I go ahead and find a way to get a list of [major.minor.patch] from python.org and then do as per the code comment?
behnazh-w
reviewed
Nov 24, 2025
| return os.EX_OK | ||
|
|
||
|
|
||
| def gen_dockerfile(buildspec: BaseBuildSpecDict) -> str: |
Member
There was a problem hiding this comment.
It would be good to refactor this function and move it to a new sub-package for Docker formats, and a module for pypi specifically.
Signed-off-by: Abhinav Pradeep <[email protected]>
Signed-off-by: Abhinav Pradeep <[email protected]>
AbhinavPradeep
force-pushed
the
abhinav/generate-dockerfile-output
branch
from
61a5195 to
853852b
Compare
behnazh-w
reviewed
Nov 27, 2025
Signed-off-by: Abhinav Pradeep <[email protected]>
behnazh-w
reviewed
Nov 28, 2025
Member
behnazh-w
left a comment
behnazh-w
left a comment
There was a problem hiding this comment.
Please add an integration test for the docker package used in the tutorial, and use the tutorial tag. For now, we can just compare the dockerfile output with the expected Dockerfile.
| Rebuilding a Python wheel | ||
| ************************* | ||
|
|
||
| The above workflow can be adopted to generate build specifications for Python wheels, often distributed via PyPi, as well. Consider the purl ``pkg:pypi/[email protected]``. We can run analyze like: |
Member
There was a problem hiding this comment.
Suggested change
| The above workflow can be adopted to generate build specifications for Python wheels, often distributed via PyPi, as well. Consider the purl ``pkg:pypi/[email protected]``. We can run analyze like: | |
| The above workflow can be adopted to generate build specifications for Python wheels, often distributed via PyPI, as well. Consider the purl ``pkg:pypi/[email protected]``. We can run analyze like: |
| ./run_macaron.sh analyze -purl pkg:pypi/[email protected] | ||
| As with the Maven example, we can also generate a JSON buildspec if we wish to. For the purposes of this tutorial, we will generate a dockerfile output. To do so, we can run ``gen-build-spec`` with the output format flag set to ``dockerfile`` as below: |
Member
There was a problem hiding this comment.
Suggested change
| As with the Maven example, we can also generate a JSON buildspec if we wish to. For the purposes of this tutorial, we will generate a dockerfile output. To do so, we can run ``gen-build-spec`` with the output format flag set to ``dockerfile`` as below: | |
| Similar to the Maven example, it is also possible to generate a JSON buildspec. However, for this tutorial, we will generate a ``dockerfile`` output. To do this, run ``gen-build-spec`` with the ``--output-format`` flag set to ``dockerfile``, as shown below: |
…ion. Signed-off-by: Abhinav Pradeep <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds option "dockerfile" to the --output-format flag for gen-build-spec. For Python packages, it generates a dockerfile built on the
oraclelinux:9image to rebuild the package.Description of changes
build_spec_generator.pyto add functionality to infer the latest Python interpreter version satisfying the packages constraints, and generate a dockerfile that would build that Python interpreter from source. The dockerfile then proceeds to use that built interpreter to build the package itself.