feat: ability to use only precomputed point predictions #4
+50
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to train and use a macest model only from precomputed point predictions. This allows to have no reference to the point predcition model in the macest model, which makes the loading/saving and usage of these models easier. The following changes are introduced:
model
orpoint_pred_model
argument in__init__
becomes optionalprec_point_preds
is added toModelWithConfidence.fit
,ModelWithConfidence.predict_confidence_of_point_prediction
,ModelWithPredictionInterval.predict_interval
andModelWithPredictionInterval.fit
update_empirical_conflict_constant
is added to_TrainingHelper.fit
. It allows to skip the stepfind_conflicting_predictions
Signed-off-by: Florent Rambaud flo.rambaud@gmail.com