Skip to content

Added support for ingress-level listener port annotations #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

piyush-tiwari
Copy link
Member

  • Added Ingress level listener port annotations, allowing users to specify a single port to multiplex their http(s) traffic through for an ingress
  • Fixed default backend determination

- Added Ingress level listener port annotations, allowing users to specify a single port to multiplex their http(s) traffic through for an ingress
- Fixed default backend determination
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 6, 2024
@coveralls
Copy link

coveralls commented Jun 6, 2024

Pull Request Test Coverage Report for Build 9395833412

Details

  • 62 of 76 (81.58%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 65.628%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/state/ingressstate.go 18 20 90.0%
pkg/controllers/routingpolicy/util.go 8 14 57.14%
pkg/util/util.go 34 40 85.0%
Totals Coverage Status
Change from base Build 9367570113: 0.2%
Covered Lines: 2316
Relevant Lines: 3529

💛 - Coveralls

@piyush-tiwari piyush-tiwari requested a review from nirpai June 6, 2024 06:30
@piyush-tiwari piyush-tiwari merged commit e45f992 into main Jun 6, 2024
4 checks passed
@piyush-tiwari piyush-tiwari deleted the add-listener-port-annotation branch June 26, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants