Skip to content

Fix finalizer removal logic for ingresses#87

Merged
piyush-tiwari merged 1 commit intomainfrom
dev-piytiwar
Jul 24, 2024
Merged

Fix finalizer removal logic for ingresses#87
piyush-tiwari merged 1 commit intomainfrom
dev-piytiwar

Conversation

@piyush-tiwari
Copy link
Member

Currently, OCI Native Ingress Controller does not remove its guarding finalizer from Ingresses in these scenarios -

  • Change of Ingress.Spec.IngressClassName to an IngressClass that is not handled by OCI NIC
  • Non-existence of IngressClass corresponding to Ingress.Spec.IngressClassName, possibly because the IngressClass was deleted before Ingresses attached to it were

This fix adds code to remove finalizers in such scenarios, marking the Ingress free to delete as the backing LB resources do not exist.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 24, 2024
@coveralls
Copy link

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10072714911

Details

  • 3 of 9 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 66.501%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/ingress/ingress.go 0 6 0.0%
Totals Coverage Status
Change from base Build 10002993988: -0.03%
Covered Lines: 2412
Relevant Lines: 3627

💛 - Coveralls

@piyush-tiwari piyush-tiwari merged commit 8218667 into main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants