-
Notifications
You must be signed in to change notification settings - Fork 775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid global isHistoryEnabled() checks in favor of per repository check #4746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92c4fa9
to
3fca07a
Compare
vladak
commented
Mar 19, 2025
opengrok-indexer/src/main/java/org/opengrok/indexer/analysis/AnalyzerGuru.java
Show resolved
Hide resolved
vladak
commented
Mar 19, 2025
opengrok-indexer/src/main/java/org/opengrok/indexer/configuration/Configuration.java
Show resolved
Hide resolved
vladak
commented
Mar 19, 2025
opengrok-indexer/src/main/java/org/opengrok/indexer/index/Indexer.java
Outdated
Show resolved
Hide resolved
opengrok-web/src/main/java/org/opengrok/web/api/v1/controller/ProjectsController.java
Show resolved
Hide resolved
ginoaugustine
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for real per project history override.
Tested with indexer running with:
where the contents of
/var/opengrok/etc/readonly_configuration-per_project_history.xml
looked like this:The source root had two projects, each with single Git repository, named
foo
andbar
. I ran two tests, one with global history on and per project/repository off and vice versa. Checked thelist
/minisearch
JSPs in debugger for each test.Also ran indexer with and without -H to make sure the history is disabled by default as before the change and also that the history cache is created if history is on (to test the
AnalyzerGuru
changes).Also tested in project-less mode.