Skip to content

Added graalvm compilation #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

Added graalvm compilation #1443

wants to merge 40 commits into from

Conversation

Lemap1
Copy link
Contributor

@Lemap1 Lemap1 commented Jul 9, 2025

With those new code midifications, when building in standalone mode, it create a native lib and executable using graalvm. Linked to issue #1442.

@nicolas-f
Copy link
Member

please do not commit generated files. Add generated folders into .gitignore.

This is too late, so maybe this pull request will be squashed into a single commit to remove commited generated files

@Lemap1
Copy link
Contributor Author

Lemap1 commented Jul 9, 2025

Yes sorry i realized after doing the PR that i did not managed the files generated on a build. I'm doing commits to solve this.

@nicolas-f nicolas-f requested review from nicolas-f and ebocher July 9, 2025 12:02
@Lemap1
Copy link
Contributor Author

Lemap1 commented Jul 9, 2025

OK it seems to be good, there's no more generated files in the PR @nicolas-f.

@nicolas-f
Copy link
Member

is the github action generate the native libraries ?

@Lemap1
Copy link
Contributor Author

Lemap1 commented Jul 9, 2025

In both release and snapshot modes, the workflow builds the standalone version, so it should also build the native library and executable (at least for Linux, since the action runs on a Linux runner, not Windows).
However, I'm not very familiar with GitHub pipelines. Does the action automatically save the output (e.g., the native library and executable in this case) as artifacts, or should I explicitly add a step to store them?

Copy link
Member

@ebocher ebocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the job

First pass with some commentes

@Lemap1 Lemap1 marked this pull request as draft July 18, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants