Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the culprit dependency from the codebase as part of a larger effort tracked in issue #262. The changes convert all error handling from culprit::Result with context tracking to standard Rust Result types.
Key changes:
- Removed
culpritdependency fromCargo.tomlandCargo.lock - Converted all function signatures from
culprit::Result<T, E>toResult<T, E> - Simplified error construction from
Culprit::new(err)to direct error returns - Removed culprit-specific method calls like
.or_into_ctx()and.ctx() - Updated
assert_error!macro to work with standardResulttypes - Updated documentation examples to reflect the new error handling
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Removed culprit = "0.4" dependency |
| Cargo.lock | Removed culprit and smallvec (transitive dependency) package entries |
| src/testutil.rs | Updated assert_error! macro to not call .ctx() on errors |
| src/splinter_ref.rs | Converted public API from_bytes to return Result<Self, DecodeErr>, removed Culprit wrapper usage and import, updated doc example |
| src/cow.rs | Converted public API from_bytes to return Result<Self, DecodeErr>, removed Culprit import |
| src/codec.rs | Converted ensure_bytes_available to return standard Result, removed direct error wrapping with Culprit::new(), removed Culprit import |
| src/codec/tree_ref.rs | Converted from_suffix to return standard Result |
| src/codec/runs_ref.rs | Converted from_suffix to return standard Result, removed .or_into_ctx() call and ResultExt import |
| src/codec/partition_ref.rs | Converted all function signatures to standard Result, removed .or_into_ctx() calls and ResultExt import, cleaned up function formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a push in Graft: orbitinghail/graft#262