chore: add validation removing trailing / from api endpoint #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickb-orca
approved these changes
Feb 17, 2025
|
Created a PR to fix that linting test. Standby. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having a little bother configuring the correct API endpoint and getting some confusing
404errors - I ended up contacting Orca support, after a little digging and double checking, it turned out to be the trailing/in my provider config.One of the support engineers mentioned he lost quite a bit of time to chasing this down previously which is why he knew to check it.
Adding this should hopefully save other users some time in the future and save Orca support from spending any more time on this particular issue.
This change is minor and passes all tests locally.
When a trailing
/is removed, a warning entry is added to the terraform log for debug purposes.