-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Extend properties CDDL with attributes #4243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Few more things came to mind.
|
I'm wondering about this. I think most links are explanatory. For example, if it's a link to
I think that they're presented differently. Traits should be grouped under together, but project links definitely don't belong with traits. This seems better:
Than this:
The all seem reasonably useful and reasonably easy to implement. But if you think one in particular isn't useful, then feel free to suggest that we remove it. |
|
Proportion is actually one of the very few data types which is supported by OpenSea, so I think we should have it for coverage of what people use for ERC-721s. I think it also gets some use for "power level" type stuff. Bytes I agree is maybe niche, but raw bytes are elemental, so I definitely want people to be able to use them.
My thinking is that I definitely usually think changes should be minimal, but adding different value types just seems easy enough. |
Fixes #4222. As a first stab, just extend the CDDL.
To do: