import descriptor on --dry-run
#4377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphjaph
requested changes
Jul 22, 2025
Comment on lines
+81
to
+84
| if !self.no_backup { | ||
| Self::backup_recovery_key(wallet, recovery_key_pair)?; | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't really want to pollute the backups with keys for transactions that are potentially not broadcast. I would be fine with printing out the key to accomodate your use case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
dry-runonord wallet inscribe --dry-runwill return the commit and reveal psbts, we can sign (bitcoin-cli walletprocesspsbt) and broadcast(bitcoin-cli sendrawtransaction)the commit transaction but we won't be able to spend the generated utxo (the first output) because our wallet will not have the taproot descriptor to spend itThis PR adds the
backup_recovery_keyto thedry_runas well.