Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tui): stop the event handler on quit #24

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

orhun
Copy link
Owner

@orhun orhun commented Sep 13, 2024

Description of change

I realized we are not stopping the event handling loop when the restart command is send.

fixes #13

How has this been tested? (if applicable)

Locally.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 3.67%. Comparing base (236d19e) to head (c3f4a0d).

Files with missing lines Patch % Lines
src/lib.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #24      +/-   ##
========================================
- Coverage   3.67%   3.67%   -0.00%     
========================================
  Files         18      18              
  Lines       2212    2213       +1     
========================================
  Hits          81      81              
- Misses      2131    2132       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit d42b670 into main Sep 17, 2024
13 of 14 checks passed
@orhun orhun deleted the fix/clean_up_terminal branch September 17, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: TUI crash after opening a dependency and then quitting binsider
2 participants