-
-
Notifications
You must be signed in to change notification settings - Fork 256
ci: check builds without cross #1198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is purely an experiment to check whether cross is necessary to build the various targets
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
==========================================
- Coverage 43.34% 43.29% -0.04%
==========================================
Files 22 22
Lines 2054 2054
==========================================
- Hits 890 889 -1
- Misses 1164 1165 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
77b6413 to
0e72383
Compare
|
Ok, so it looks like this works. The changes to the other PR are:
All of this seems pretty logical. So cross isn't necessary to build all the targets that you're building here. It's likely the matrix could be simplified a fair bit easily. |
e28e298 to
eaf6937
Compare
|
TODO - back merge the changes in this into the other PR |
|
So the verdict is we don't need cross I guess 👀 |
Followup to #1193 (comment)
This is a do not merge PR, it's just there to check whether cross is necessary for any of the build targets.
That said, it's possible that you might want to split the build and publish steps and use the artifacts of the build step in the publish step in the actual real world case. This would give you the ability to ensure that these builds work without having to publish check.