Skip to content

Fix bug where stable sync is used when sorting is enabled #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

arnaudsjs
Copy link
Contributor

No description provided.

Copy link

netlify bot commented May 21, 2025

Deploy Preview for mypy-baseline ready!

Name Link
🔨 Latest commit b350956
🔍 Latest deploy log https://app.netlify.com/projects/mypy-baseline/deploys/682d9c12e04c0900099be01d
😎 Deploy Preview https://deploy-preview-27--mypy-baseline.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@arnaudsjs
Copy link
Contributor Author

I also think there is a bug in the _stable_sync() method. When preserve_position==False it can happen that the same type error occurs multiples times in the same module (because the line numbers are set to 0). If that is the case and only once occurrence of the type error is resolved, the added and the removed sets in the _stable_sync() method will be both empty. The result is that no changes will be made to the baseline file. However, when running mypy-baseline filter, it will report a diff. Do you agree this is a bug?

@orsinium
Copy link
Member

Thank you!

@orsinium orsinium merged commit 1b2af40 into orsinium-labs:master May 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants