Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add page header component with user menu #223

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Conversation

mszekiel
Copy link
Collaborator

@mszekiel mszekiel commented Oct 8, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@mszekiel mszekiel changed the title Feat/ax user menu feat: ax page header with user menu Oct 8, 2024
@mszekiel mszekiel changed the base branch from main to jonas-jonas/elementsv1 October 8, 2024 15:22
Base automatically changed from jonas-jonas/elementsv1 to main October 16, 2024 12:55
An error occurred while trying to automatically change base from jonas-jonas/elementsv1 to main October 16, 2024 12:55
@mszekiel mszekiel marked this pull request as ready for review October 16, 2024 15:46
@mszekiel mszekiel self-assigned this Oct 16, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 71.95122% with 23 lines in your changes missing coverage. Please review.

Project coverage is 51.91%. Comparing base (a2a032e) to head (f068a2b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eact/src/theme/default/components/ui/user-menu.tsx 52.63% 9 Missing ⚠️
.../src/theme/default/components/ui/dropdown-menu.tsx 75.00% 6 Missing ⚠️
...c/theme/default/components/generic/page-header.tsx 50.00% 3 Missing ⚠️
...ments-react/src/components/generic/page-header.tsx 50.00% 2 Missing ⚠️
...ct/src/theme/default/components/ui/user-avater.tsx 66.66% 2 Missing ⚠️
...ges/elements-react/src/theme/default/utils/user.ts 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   50.05%   51.91%   +1.85%     
==========================================
  Files          94      103       +9     
  Lines         913      994      +81     
  Branches      115      122       +7     
==========================================
+ Hits          457      516      +59     
- Misses        452      473      +21     
- Partials        4        5       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas merged commit cbf29d8 into main Oct 22, 2024
12 checks passed
@jonas-jonas jonas-jonas changed the title feat: ax page header with user menu feat: add page header component with user menu Oct 22, 2024
@jonas-jonas jonas-jonas deleted the feat/ax-user-menu branch October 22, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants