Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use translations in more missing places #239

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.95%. Comparing base (d719e15) to head (eb0c608).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   51.95%   51.95%           
=======================================
  Files         103      103           
  Lines         995      995           
  Branches      122      122           
=======================================
  Hits          517      517           
  Misses        473      473           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas force-pushed the jonas-jonas/fixMoreTranslations branch from 6a52b4e to 25fd584 Compare October 24, 2024 10:20
@jonas-jonas jonas-jonas marked this pull request as ready for review October 24, 2024 10:20
@jonas-jonas jonas-jonas merged commit 53799f6 into main Oct 24, 2024
8 of 12 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixMoreTranslations branch October 24, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant