feat: add support for Line v2.1 OIDC provider and update related conf… #4240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igurations Update provider_line_2_1.go
|
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aeneasr
reviewed
Jan 2, 2025
Member
aeneasr
left a comment
aeneasr
left a comment
There was a problem hiding this comment.
Thank you very much! Could you please also add to the docs a guide for Line? See here for an example: ory/docs#1693
Sorry for the long wait on your PR and congrats to your first submission! :)
aeneasr
approved these changes
Jan 2, 2025
David-Wobrock
added a commit
to David-Wobrock/docs
that referenced
this pull request
Jan 14, 2025
6 tasks
Contributor
|
Hello! Thank you very much for this @jack-r-hong ❤️ In order to contribute, here is the documentation PR ory/docs#2006 @aeneasr |
David-Wobrock
added a commit
to David-Wobrock/docs
that referenced
this pull request
Jan 15, 2025
David-Wobrock
added a commit
to David-Wobrock/docs
that referenced
this pull request
Jan 20, 2025
David-Wobrock
added a commit
to David-Wobrock/docs
that referenced
this pull request
Jan 22, 2025
David-Wobrock
added a commit
to David-Wobrock/docs
that referenced
this pull request
Jan 28, 2025
David-Wobrock
added a commit
to David-Wobrock/docs
that referenced
this pull request
Feb 7, 2025
alnr
approved these changes
May 13, 2025
Contributor
|
Thank you! |
David-Wobrock
added a commit
to David-Wobrock/docs
that referenced
this pull request
May 15, 2025
alnr
pushed a commit
to ory/docs
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, this is my first time contributing code. If you have any suggestions, please feel free to let me know. For OIDC Line Login, you only need to add id_token_key_type=JWK in the exchange step to issue tokens in HS256 format.
Related issue(s)
#1116
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments