Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error when emiting an AMQP job event when the job does not exist #6243

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented Mar 4, 2025

  • Ignore non-existing jobs when trying to emit an AMQP event
    • This can happen when the job has been deleted meanwhile, e.g. via the API or during cleanup. It makes no sense to emit e.g. a job_done event when the job has already been deleted anyway.
    • This can also happen on concurrent deletions where one event is enough.
  • Treat non-existing jobs similar to non-existing comments which we already ignore
  • Avoid error observed in https://progress.opensuse.org/issues/178126

* Ignore non-existing jobs when trying to emit an AMQP event
    * This can happen when the job has been deleted meanwhile, e.g. via
      the API or during cleanup. It makes no sense to emit e.g. a
      `job_done` event when the job has already been deleted anyway.
    * This can also happen on concurrent deletions where one event is
      enough.
* Treat non-existing jobs similar to non-existing comments which we already
  ignore
* Avoid error observed in https://progress.opensuse.org/issues/178126
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (6b8160f) to head (b7f4413).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6243   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         398      398           
  Lines       40017    40017           
=======================================
  Hits        39623    39623           
  Misses        394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@okurz okurz merged commit 91a948a into os-autoinst:master Mar 4, 2025
45 checks passed
@Martchus Martchus deleted the amqp-error branch March 4, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants