Also use try/catch in Controller::API::V1::Comment

[okurz]

The txn_guard needs an explicit undef in catch

Related progress issue: https://progress.opensuse.org/issues/176862

[Martchus]

Not really an improvement.

[Martchus]

Suggested change

	try { $comment->handle_special_contents($self) }
	catch ($e) {
	undef $txn_guard;
	return $self->render(json => {error => $e}, status => 400);
	}
	eval { $comment->handle_special_contents($self) }; # using eval as the txn guard interacts badly with try-catch
	return $self->render(json => {error => $@}, status => 400) if $@;

[okurz]

The advantage would be that we can filter for $@ usage, only leaving eval where we are not using the error message.

Let me demonstrate that in

• Consistently use try/catch instead of 'if ' everywhere #6303

how do you like that?

[Martchus]

The case where we need to undefine the txn guard is still worse.

I also don't see it as necessity to enforce use of try-catch and thus filtering doesn't seem very useful. As long as we don't use Try::Tiny anymore which has counter-intuitive behavior for everyone coming from different programming languages we're good.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (29123e3) to head (df72dae).
Report is 85 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6262   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         398      398           
  Lines       40014    40020    +6     
=======================================
+ Hits        39620    39626    +6     
  Misses        394      394           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[perlpunk]

The advantage would be that we can filter for $@ usage, only leaving eval where we are not using the error message.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏

[okurz]

included with #6303