Skip to content

Improve "from" time label in /tests/overview #6300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Mar 19, 2025
Merged

Improve "from" time label in /tests/overview #6300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions t/10-tests_overview.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ subtest 'time parameter' => sub {
my @params = (distri => 'opensuse', version => 'Factory', build => '87.5011');
my $tp = '2020-01-01T00:00:00';
$t->get_ok('/tests/overview' => form => {@params, t => $tp});
like(get_summary, qr/from $tp.*show latest jobs$/s, 'jobs newer than time parameter filtered out');
like(get_summary, qr/at the time of $tp.*show latest jobs$/s, 'jobs newer than time parameter filtered out');
$t->get_ok('/tests/overview' => form => {@params, t => time2str('%Y-%m-%d %H:%M:%S', time, 'UTC')});
like(get_summary, qr/from.*show latest.*Incomplete: 1$/s, 'jobs newer than time parameter shown');
like(get_summary, qr/at the time of.*show latest.*Incomplete: 1$/s, 'jobs newer than time parameter shown');
};

# Advanced query parameters can be forwarded
Expand Down
2 changes: 1 addition & 1 deletion templates/webapi/test/overview.html.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
% }
<div class="time-params">
% if ($until) {
from <abbr class="timeago" title="<%= $until %>Z"><%= $until %>Z</abbr>,
at the time of <abbr class="timeago" title="<%= $until %>Z"><%= $until %>Z</abbr>,
<a href="<%= url_with->query({t => undef}) %>">show latest jobs</a>
% }
% else {
Expand Down