Skip wait_boot for autoyast installations #17721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdoucha
reviewed
Sep 7, 2023
frankenmichl
force-pushed
the
fix_autoyast_wait_boot
branch
from
68792da to
3d17a57
Compare
|
Verification run: https://openqa.suse.de/tests/12048649 |
frankenmichl
force-pushed
the
fix_autoyast_wait_boot
branch
from
3d17a57 to
59a7f35
Compare
When we deploy the system with autoyast, there is no reboot after the installation and wait_boot never sees a grub menu, so let's skip this in this case. Signed-off-by: Michael Moese <[email protected]>
frankenmichl
force-pushed
the
fix_autoyast_wait_boot
branch
from
59a7f35 to
8470f59
Compare
Martchus
reviewed
Sep 8, 2023
Co-authored-by: Martchus <[email protected]>
mdoucha
previously requested changes
Sep 8, 2023
|
@Julie-CAO Please have a look whether this will work correctly with VIRT_AUTOTEST. |
thanks for asking. |
frankenmichl
force-pushed
the
fix_autoyast_wait_boot
branch
from
ebe9707 to
3fb9f70
Compare
|
So we can keep this a bit simpler |
Co-authored-by: Martchus <[email protected]>
frankenmichl
force-pushed
the
fix_autoyast_wait_boot
branch
from
3fb9f70 to
b666222
Compare
Martchus
approved these changes
Sep 11, 2023
mdoucha
approved these changes
Sep 11, 2023
|
New verification run: https://openqa.suse.de/tests/12078155 |
|
Yes, the commits should be squashed. You can do this directly on GitHub when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we deploy the system with autoyast, there is no reboot after the installation and wait_boot never sees a grub menu, so let's skip this in this case.
This will fix https://openqa.suse.de/tests/11998046 and similar