-
Notifications
You must be signed in to change notification settings - Fork 293
Utilize agama.install_url #20064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize agama.install_url #20064
Conversation
21b4afb
to
93b16fe
Compare
3e853e2
to
addbf30
Compare
There is a one problem though ... it seems that we have issue with the download proxy on the openQA side. The value is taken from https://openqa.opensuse.org/tests/4439721#settings passed (and somehow auto-modified to start with the proxy ) in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/20064/files#diff-05f9f9adf140de4c57ec6f1c3f1034ef825689b5d16949ac3de6ea8655d768d3R595 |
Can we get the |
Oky Fabian told me that I should not be passing public url with data. |
addbf30
to
186cffd
Compare
186cffd
to
9639444
Compare
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
1 similar comment
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
906f9f7
to
e758b12
Compare
e758b12
to
0b00459
Compare
* Introduced in agama-project/agama#1545 * Pass REPO_0 as a param to it agama supports, comma separated list as agama.install_url boot param * Agama boot entry finally done through needle match
0b00459
to
42dcf03
Compare
let's make this in a separate PR after this one so we get unblocked. I'll make that happen. |
Oky the url is finally working. Had to be deployed to actually rsync the data os-autoinst/openqa-trigger-from-obs#263 and then I shall not use data_url for synced directory. |
Co-authored-by: Martchus <[email protected]>
wait_screen_change { send_key "e" }; | ||
send_key "down"; | ||
send_key "down"; | ||
send_key "down"; | ||
send_key "down"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor comment here, could you use send_key_until_needlematch
instead? anyway, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rfan1 but we're talking about needling until the _ is in front of linux entry ... I'm really afraid that this will cause more future work with re-needling especially if font/theme changes. While the send_key down 4 times, will work probably forever unless we reoder grub which usually doesn't happen in lifespan of a major version (e.g. 16.X or 15.X). Also the fact that it's just a little underscore in front of linux, and not highlighted line or similar its making it more tricky.
I'll make it a separate PR as I seem to have an issue with switch back to X11. |
introduced in openQA: Allow overriding of install repos #1474 agama-project/agama#1545
USE REPO_0 var which contains the repo path (was AGAMA_INSTALL_URL in test suite)
openqa-clone-job --within-instance https://openqa.opensuse.org/tests/4438312 --skip-chained-deps YAML_SCHEDULE=schedule/install/agama_install.yaml REPO_0=Leap-16.0-aarch64-ppc64le-s390x-x86_64-Build2.4 AGAMA=1 _GROUP=0 _LIVETEST=0 LIVETEST=0 [email protected]:lkocman/os-autoinst-distri-opensuse.git#agama_install_url