Skip to content

Utilize agama.install_url #20064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

lkocman
Copy link
Contributor

@lkocman lkocman commented Aug 27, 2024

@lkocman lkocman marked this pull request as draft August 27, 2024 15:29
@lkocman lkocman force-pushed the agama_install_url branch 16 times, most recently from 21b4afb to 93b16fe Compare August 28, 2024 12:16
@lkocman lkocman marked this pull request as ready for review August 28, 2024 12:17
@lkocman lkocman force-pushed the agama_install_url branch 2 times, most recently from 3e853e2 to addbf30 Compare August 28, 2024 12:32
@lkocman
Copy link
Contributor Author

lkocman commented Aug 28, 2024

There is a one problem though ... it seems that we have issue with the download proxy on the openQA side.

The value is taken from https://openqa.opensuse.org/tests/4439721#settings

passed (and somehow auto-modified to start with the proxy ) in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/20064/files#diff-05f9f9adf140de4c57ec6f1c3f1034ef825689b5d16949ac3de6ea8655d768d3R595

But agama can't access it
image

@lslezak
Copy link
Contributor

lslezak commented Aug 28, 2024

Can we get the /var/log/YaST2/y2log file somehow?

@lkocman
Copy link
Contributor Author

lkocman commented Aug 28, 2024

Oky Fabian told me that I should not be passing public url with data.
the obs openqa sync stores repo url in the file repo_url so we should probably grab it from there.

@lkocman lkocman closed this Sep 4, 2024
@lkocman lkocman reopened this Sep 4, 2024
Copy link

github-actions bot commented Sep 4, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

1 similar comment
Copy link

github-actions bot commented Sep 4, 2024

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

* Introduced in agama-project/agama#1545
* Pass REPO_0 as a param to it agama supports, comma separated list
  as agama.install_url boot param
* Agama boot entry finally done through needle match
@lkocman
Copy link
Contributor Author

lkocman commented Sep 4, 2024

Can we get the /var/log/YaST2/y2log file somehow?

let's make this in a separate PR after this one so we get unblocked. I'll make that happen.

@lkocman
Copy link
Contributor Author

lkocman commented Sep 4, 2024

Oky the url is finally working. Had to be deployed to actually rsync the data os-autoinst/openqa-trigger-from-obs#263 and then I shall not use data_url for synced directory.

@lkocman lkocman requested a review from Martchus September 4, 2024 15:24
Comment on lines +587 to +591
wait_screen_change { send_key "e" };
send_key "down";
send_key "down";
send_key "down";
send_key "down";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment here, could you use send_key_until_needlematch instead? anyway, LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfan1 I'll make it since @Martchus mentioned the same :-) And if two people already see the same problem, then it seems to be a legit one.

Copy link
Contributor Author

@lkocman lkocman Sep 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rfan1 but we're talking about needling until the _ is in front of linux entry ... I'm really afraid that this will cause more future work with re-needling especially if font/theme changes. While the send_key down 4 times, will work probably forever unless we reoder grub which usually doesn't happen in lifespan of a major version (e.g. 16.X or 15.X). Also the fact that it's just a little underscore in front of linux, and not highlighted line or similar its making it more tricky.

image

@lkocman
Copy link
Contributor Author

lkocman commented Sep 5, 2024

Can we get the /var/log/YaST2/y2log file somehow?

I'll make it a separate PR as I seem to have an issue with switch back to X11.
https://github.com/lkocman/os-autoinst-distri-opensuse/tree/agama_logs
https://openqa.opensuse.org/tests/4455118#step/agama/184

@rfan1 rfan1 merged commit dcdf536 into os-autoinst:master Sep 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants