Skip to content

Add test for gnome-console (kgx) #21557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

foursixnine
Copy link
Member

@foursixnine foursixnine commented Mar 24, 2025

Gnome terminal is being replaced with gnome-console (kgx) this PR prepares the groundwork for that change

Progress ticket: https://progress.opensuse.org/issues/169162
Needles: os-autoinst/os-autoinst-needles-opensuse#827
VR:

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@dzedro
Copy link
Contributor

dzedro commented Mar 24, 2025

Should then x11/gnome_terminal not run on 16 ?

@foursixnine
Copy link
Member Author

Should then x11/gnome_terminal not run on 16 ?

In theory it shouldn't, but at the moment the package is still available, thus should be tested (a pr adding ensure_installed on x11/gnome_terminal will come at a later point

Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foursixnine foursixnine merged commit 02e10f5 into os-autoinst:master Mar 25, 2025
11 checks passed
@foursixnine foursixnine deleted the addkgx branch March 25, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants