Skip to content

Add SEV-SNP guest verification test module #22445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

RoyCai7
Copy link
Contributor

@RoyCai7 RoyCai7 commented Jun 24, 2025

[Progress ticket: https://progress.opensuse.org/issues/181193

Features:

  • Host-side SEV-SNP support verification with kernel parameter validation
  • Guest VM configuration for SEV-SNP with XML modification
  • Guest-side SEV-SNP activation verification via dmesg analysis
  • Attestation report generation and verification
  • Comprehensive log collection for debugging
  • Support for 15-SP7 MU, and SLES 16+
  • Handles incompatible features removal (TPM, SMM, memoryBacking)
  • Integration with Confidential Computing module activation
  • The test supports both MU and unified guest installation
    modes.

New Flavors for sle15sp7 sev-snp testing:

  • Server-DVD-Incidents-VIRT-Core
  • Server-DVD-Incidents-VIRT-Tools-CoCo

Metadata MR:
https://gitlab.suse.de/qa-maintenance/metadata/-/merge_requests/1436

Currently, Kaylee is the only machine configured for SLES 15 SP7 SEV-SNP testing, and bare-metal1 is the only one set up for SLES 16 SEV-SNP testing.

Job group MR:
https://gitlab.suse.de/qa-testsuites/openqa-job-group-yaml/-/merge_requests/286

New workerclass MR:
https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/1098

For MU machine, will set new workerclass on void server.

VR:

sle16 sev-snp testing:
Bare-metal1: https://openqa.suse.de/tests/18552472
Bare-emtal2: https://openqa.suse.de/tests/18561625

sle15sp7 sev-snp testing:
Kaylee: https://openqa.suse.de/tests/18494902
River: https://openqa.suse.de/tests/18563802

sle16 related test(sev-es):
sle-16.0-Online-x86_64-Build119.1-sev-es-gi-guest_developing-on-host_developing-kvm@64bit-ipmi-amd-zen3-uefi

sle15 MU testing
sle15sp5 sriov testing

Copy link

Great PR! Please pay attention to the following items before merging:

Files matching lib/**.pm:

  • Consider adding or extending unit tests in t/

This is an automatically generated QA checklist based on modified files.

@RoyCai7 RoyCai7 force-pushed the sev-snp branch 29 times, most recently from a09ac2c to 2194eae Compare July 1, 2025 17:01
@RoyCai7 RoyCai7 force-pushed the sev-snp branch 14 times, most recently from 975ab60 to aa7af64 Compare July 19, 2025 02:07
@RoyCai7 RoyCai7 marked this pull request as ready for review July 19, 2025 05:25
@RoyCai7
Copy link
Contributor Author

RoyCai7 commented Jul 21, 2025

@RoyCai7 For maintenance mode test,

Done.
New Falvors:
Server-DVD-Incidents-VIRT-Core
Server-DVD-Incidents-VIRT-Tools-CoCo

MR: https://gitlab.suse.de/qa-maintenance/metadata/-/merge_requests/1436

@RoyCai7 RoyCai7 force-pushed the sev-snp branch 4 times, most recently from ecf630c to 05b9d5d Compare July 21, 2025 03:09
@RoyCai7 RoyCai7 requested a review from alice-suse July 21, 2025 03:09
@alice-suse
Copy link
Contributor

alice-suse commented Jul 22, 2025

@RoyCai7 For maintenance mode test,

Done. New Falvors: Server-DVD-Incidents-VIRT-Core-CoCo Server-DVD-Incidents-VIRT-Tools-CoCo Server-DVD-Incidents-VIRT-Kernel-CoCo

MR: https://gitlab.suse.de/qa-maintenance/metadata/-/merge_requests/1436

Hi @RoyCai7 The code LGTM. I think it is close to merge :) . Let's wait longer for others review.

BTW, I do not see the MR for job group yaml of sle16 and MU. Will you create one?
Besides, this is big PR which may have impacts to existing tests. Would you please add some regression test for MU, sle16 uefi vm and sev-es and copy the jobs here? At last, there is no jobs for failure tests which can show that the needed logs are uploaded. Is it possible to add some key failure jobs (may need some fake hard-coded return code to trigger the errors)?

progress ticket: https://progress.opensuse.org/issues/181193

Features:
Host-side SEV-SNP support verification with kernel parameter validation
Guest VM configuration for SEV-SNP with XML modification
Guest-side SEV-SNP activation verification via dmesg analysis
Attestation report generation and verification
Comprehensive log collection for debugging
Support for SLES 15-SP6, 15-SP7, and SLES 16+
Handles incompatible features removal (TPM, SMM, memoryBacking)
Integration with Confidential Computing module activation
The test supports both MU and unified guest installation
modes.
@RoyCai7
Copy link
Contributor Author

RoyCai7 commented Jul 28, 2025

@RoyCai7 For maintenance mode test,

Done. New Falvors: Server-DVD-Incidents-VIRT-Core-CoCo Server-DVD-Incidents-VIRT-Tools-CoCo Server-DVD-Incidents-VIRT-Kernel-CoCo
MR: https://gitlab.suse.de/qa-maintenance/metadata/-/merge_requests/1436

Hi @RoyCai7 The code LGTM. I think it is close to merge :) . Let's wait longer for others review.

BTW, I do not see the MR for job group yaml of sle16 and MU. Will you create one? Besides, this is big PR which may have impacts to existing tests. Would you please add some regression test for MU, sle16 uefi vm and sev-es and copy the jobs here? At last, there is no jobs for failure tests which can show that the needed logs are uploaded. Is it possible to add some key failure jobs (may need some fake hard-coded return code to trigger the errors)?

Done, please check: #22445 (comment)

@RoyCai7 RoyCai7 requested a review from alice-suse July 28, 2025 15:37
Copy link
Contributor

@alice-suse alice-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alice-suse
Copy link
Contributor

Stops waiting for more review. Merge it now.

@alice-suse alice-suse merged commit 7bb2ab2 into os-autoinst:master Jul 31, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants