-
Notifications
You must be signed in to change notification settings - Fork 295
Add patterns_sles4sap schedule for hyper-v minimal-vm on SLE 16.0 #22466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a question.
bootloader: | ||
MACHINE: | ||
'uefi-virtio-vga': | ||
- boot/boot_to_desktop | ||
'svirt-hyperv-uefi': | ||
- installation/bootloader_hyperv | ||
- jeos/firstrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming we cannot publish a HDD on this hypervisor, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, indeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think about your suggestion again, it's great, if I publish a HDD, it is benefit of adding more tests for Hyper-V Minimal-VM later, however, is it better if the patterns
test merged into create_hdd
test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there is no sles_sap_base_sap_server
pattern installed in the original image SLES-SAP-16.0-Minimal-VM-x86_64-MS-HyperV-sap-Build25.27.vhdx.xz
, is it correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I practiced and make sure that openQA can't publish non-qcow2 image with PUBLISH_HDD_1
, so I updated the yaml schedule file to get more information when finishing the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think about your suggestion again, it's great, if I publish a HDD, it is benefit of adding more tests for Hyper-V Minimal-VM later, however, is it better if the
patterns
test merged intocreate_hdd
test?
Yes, I think that's OK. Not sure that we have Hyper-V workers big enough to handle other types of SAP tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that there is no
sles_sap_base_sap_server
pattern installed in the original imageSLES-SAP-16.0-Minimal-VM-x86_64-MS-HyperV-sap-Build25.27.vhdx.xz
, is it correct?
That sounds like a bug
63217cb
to
2c1f40c
Compare
LGTM. |
Update patterns.yaml to support hyper-v minimal-vm
https://openqa.suse.de/tests/18215801