Skip to content

Add patterns_sles4sap schedule for hyper-v minimal-vm on SLE 16.0 #22466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

badboywj
Copy link
Contributor

@badboywj badboywj commented Jun 25, 2025

Update patterns.yaml to support hyper-v minimal-vm

Copy link
Contributor

@mpagot mpagot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Amrysliu Amrysliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alvarocarvajald alvarocarvajald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a question.

Comment on lines 5 to 11
bootloader:
MACHINE:
'uefi-virtio-vga':
- boot/boot_to_desktop
'svirt-hyperv-uefi':
- installation/bootloader_hyperv
- jeos/firstrun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we cannot publish a HDD on this hypervisor, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, indeed.

Copy link
Contributor Author

@badboywj badboywj Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think about your suggestion again, it's great, if I publish a HDD, it is benefit of adding more tests for Hyper-V Minimal-VM later, however, is it better if the patterns test merged into create_hdd test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there is no sles_sap_base_sap_server pattern installed in the original image SLES-SAP-16.0-Minimal-VM-x86_64-MS-HyperV-sap-Build25.27.vhdx.xz, is it correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I practiced and make sure that openQA can't publish non-qcow2 image with PUBLISH_HDD_1, so I updated the yaml schedule file to get more information when finishing the test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think about your suggestion again, it's great, if I publish a HDD, it is benefit of adding more tests for Hyper-V Minimal-VM later, however, is it better if the patterns test merged into create_hdd test?

Yes, I think that's OK. Not sure that we have Hyper-V workers big enough to handle other types of SAP tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that there is no sles_sap_base_sap_server pattern installed in the original image SLES-SAP-16.0-Minimal-VM-x86_64-MS-HyperV-sap-Build25.27.vhdx.xz, is it correct?

That sounds like a bug

@badboywj badboywj force-pushed the team-10433 branch 2 times, most recently from 63217cb to 2c1f40c Compare June 26, 2025 10:52
@lilyeyes
Copy link
Contributor

LGTM.

@alvarocarvajald alvarocarvajald merged commit 91f4f62 into os-autoinst:master Jun 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants