Check agama installation if agama installer banner not shown #22489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
waynechen55
force-pushed
the
wayne/check_agama_insallation_furhter
branch
from
ff9d9fa to
c9e6f34
Compare
waynechen55
force-pushed
the
wayne/check_agama_insallation_furhter
branch
from
c9e6f34 to
0e1f83d
Compare
waynechen55
force-pushed
the
wayne/check_agama_insallation_furhter
branch
5 times, most recently
from
f45d474 to
58263cb
Compare
waynechen55
force-pushed
the
wayne/check_agama_insallation_furhter
branch
4 times, most recently
from
829c01d to
ff8c2ed
Compare
After guest installation console is re-attached, agama installer might not be shown. For agama installation, it is a bit different because agama installer shell is not a fully-fledged environment and guest needs to be rebooted after installation finishes. So it is necesary to still check agama installation progression in the subroutine check_guest_installation_result_via_ssh and add a new subroutine check_guest_installation_result.
waynechen55
force-pushed
the
wayne/check_agama_insallation_furhter
branch
from
ff8c2ed to
976ef65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After guest installation console is re-attached, agama installer might not be shown. For agama installation, it is a bit different because agama installer shell is not a fully-fledged environment and guest needs to be rebooted after installation finishes.
So it is necesary to still check agama installation progression in the subroutine
check_guest_installation_result_via_sshand add a new subroutinecheck_guest_installation_result.Verification Runs: