20220911 demo update #145
Merged
20220911 demo update #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data from not-below 2-degree JSON file. Signed-off-by: MichaelTiemann <[email protected]>
…le, and any other distance metric. Clean up other bugs found while supporting flexible new metrics. Signed-off-by: MichaelTiemann <[email protected]>
Signed-off-by: MichaelTiemann <[email protected]>
…mpound unit denominators. Signed-off-by: MichaelTiemann <[email protected]>
Signed-off-by: MichaelTiemann <[email protected]>
Also improve UX with better/fewer warnings and errors. Signed-off-by: MichaelTiemann <[email protected]>
…s functionality. Signed-off-by: MichaelTiemann <[email protected]>
|
The above changes make it possible to evaluate the sample data in order to investigate #146 |
joriscram
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a "squashed commit" of PR #139 plus some other features that round out the work I've done to improve the demo-ability and user-friendliness of the ITR tool. The previous PR trues up the units and unit-handling of the ITR tool, but without any other user-visible (or user-helpful) changes. This has all that (because new sample data doesn't work with the previous version), but also tidies up warnings and errors to make the tool more friendly. If this PR is merged into develop, then 139 should be dropped.