Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to help topic associated FAQs #507

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jeffchulg
Copy link

Addresses #395

<td><?php echo Format::htmlchars($ticket->getHelpTopic()); ?></td>
<th width="100">Help Topic:</th>
<td>
<a href="/scp/kb.php?a=search&q=&cid=&topicId=<?php echo $ticket->getTopicId()?>">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be

<a href="<?php echo sprintf("%s/scp/kb.php?a=search&topicId=%s", $cfg->getBaseUrl(), $ticket->getTopicId()); ?>">

So that the installed location (URL base) of the ticketing system is not lost

@jeffchulg
Copy link
Author

Ok, I'll change it

@greezybacon
Copy link
Contributor

@jeffchulg, would it make more sense to link to a search based on the help topic?

@jeffchulg
Copy link
Author

As you want, my point is that if a FAQ is actually a procedure, it's easy for us to just click on the link provided to get access to the corresponding procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants