-
Notifications
You must be signed in to change notification settings - Fork 78
fix: allow distro definitition override #905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This is problematic for me https://github.com/hanthor/bootc-image-builder/blob/725b710052510c35e15ff09ff571b5a8e3be83af/bib/cmd/bootc-image-builder/image.go#L505-L508 |
This logic can likely be inverted to always use |
So with distros that are based on a specific system there is always Example:
|
ID_LIKE can have multiple entries in it I think. Like Centos has rhel and fedora |
Fwiw, we inverted the #907
This part got (hopefully) fixed with #907 - is there more that is causing issues for you? FTR I'm fine with a way to override the detection, mostly wondering if there are more things we should/could fix "automatically" |
We either need to ignore edits to os-relase and find a more hardcoded way to detect the distro or allow for overrides/have helpful text for the user when the manifest isn't found guiding them to just override to fedora or centos etc. |
Fixes #904
This accepts --override-distro-def=fedora-40.yaml to set the manifest. I'm not sure if this is ideal or if it would better to have it do into the the distrodef function like normal and allow for fuzzy match