pr_check: Skip unit tests #2569
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2569 +/- ##
=======================================
Coverage 83.95% 83.95%
=======================================
Files 160 160
Lines 17882 17882
Branches 1790 1790
=======================================
Hits 15012 15012
Misses 2848 2848
Partials 22 22 Continue to review full report in Codecov by Sentry.
|
|
/retest |
We can now skip unit tests (running npn verify) in the pr_check to speed up the whole process and reduce flakiness. The unit tests are ran separately in a github action so this is fine.
regexowl
force-pushed
the
verify-optional
branch
from
b816239
to
97f9893
Compare
|
/retest |
|
This won't work yet, the required changes are merged, but the container image used needs to be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now skip unit tests (running npn verify) in the pr_check to speed up the whole process and reduce flakiness. The unit tests are ran separately in a github action so this is fine.