Skip to content

pr_check: Skip unit tests#2569

Merged
lucasgarfield merged 1 commit intoosbuild:mainfrom
jrusz:verify-optional
Nov 21, 2024
Merged

pr_check: Skip unit tests#2569
lucasgarfield merged 1 commit intoosbuild:mainfrom
jrusz:verify-optional

Conversation

@jrusz
Copy link
Contributor

@jrusz jrusz commented Nov 7, 2024

We can now skip unit tests (running npn verify) in the pr_check to speed up the whole process and reduce flakiness. The unit tests are ran separately in a github action so this is fine.

@codecov
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (58aa4f8) to head (ce3ad7e).
Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2569   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files         164      164           
  Lines       17783    17783           
  Branches     1829     1829           
=======================================
  Hits        14876    14876           
  Misses       2885     2885           
  Partials       22       22           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58aa4f8...ce3ad7e. Read the comment docs.


🚨 Try these New Features:

@jrusz
Copy link
Contributor Author

jrusz commented Nov 7, 2024

/retest

@regexowl
Copy link
Collaborator

regexowl commented Nov 7, 2024

/retest

@jrusz jrusz marked this pull request as draft November 7, 2024 12:55
@jrusz
Copy link
Contributor Author

jrusz commented Nov 7, 2024

This won't work yet, the required changes are merged, but the container image used needs to be updated.

@jrusz
Copy link
Contributor Author

jrusz commented Nov 18, 2024

/retest

@lucasgarfield lucasgarfield marked this pull request as ready for review November 21, 2024 17:52
We can now skip unit tests (running npn verify) in the pr_check to speed
up the whole process and reduce flakiness. The unit tests are ran
separately in a github action so this is fine.
Copy link
Collaborator

@lucasgarfield lucasgarfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing all the tests including pr_check, let's merge!

@lucasgarfield lucasgarfield merged commit 680d7ea into osbuild:main Nov 21, 2024
@jrusz
Copy link
Contributor Author

jrusz commented Nov 22, 2024

Passing all the tests including pr_check, let's merge!

Uhm, this was draft for a reason, that change doesn't do anything yet 😅

Also I was using this open PR to test a change in IQE plugin...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants