Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Add simple yamllint check on all .yaml files #10

Merged
merged 5 commits into from
Apr 12, 2024

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Apr 10, 2024

No description provided.

@bcl bcl force-pushed the main-yamllint branch 2 times, most recently from 5e1e603 to decd80d Compare April 10, 2024 18:11
achilleas-k
achilleas-k previously approved these changes Apr 10, 2024
ondrejbudai
ondrejbudai previously approved these changes Apr 11, 2024
supakeen
supakeen previously approved these changes Apr 11, 2024
@supakeen
Copy link
Member

supakeen commented Apr 11, 2024

Awesome thank you, I'll do a separate PR to clean up the YAML files before merging this one.

bcl added 5 commits April 11, 2024 16:56
Requires yamllint package, runs linters from the Makefile.
This turns off requiring '---' at the start of the files, and extends
the maximum line length to 120.
@bcl
Copy link
Contributor Author

bcl commented Apr 12, 2024

Awesome thank you, I'll do a separate PR to clean up the YAML files before merging this one.

Mostly did that, and added a .yamllint to control what we want to actually lint. Only one I didn't fix was the ./example/fedora/osbuild/custom/file.yaml file since I'm not sure what the intention there was.

@achilleas-k achilleas-k added this pull request to the merge queue Apr 12, 2024
Merged via the queue into osbuild:main with commit e4c82c7 Apr 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants