02-external: move common text under depsolve-dnf{4,5} #56
Conversation
The depsolve-dnf5 description was mixed up with the description below. This commit fixes this.
| @@ -4,20 +4,16 @@ | |||
|
|
|||
| These directives are only allowed within a [`otk.target.osbuild.<name>`](./01-directive.md#otktargetconsumername). | |||
There was a problem hiding this comment.
If the directives are only allowed under a specific target, we could allow users to write this shother: otk.external.osbuild.file-from-text`` -> otk.external.file-from-text`` as we know that the context is osbuild from the target. This would also ensure that users cannot use external commands that are not matching their target
There was a problem hiding this comment.
We could though I like the explicitness; I guess I'm about even on this so let's see what others feel like.
It'd feel weird to me if we had otk.external.file-from-text that does different things under different targets.
There was a problem hiding this comment.
I have no super strong opinion here but we should make sure that we do not allow using tools for targets that do not match the target target.
I am not sure if e.g. different otk.external.user implementations depending on the target would be bad, I mean, they are clearly scoped under a
otk.target.osbuild:
stages:
- otk.external.users:
and in kiwi the same. But I don't really mind much, it just seems a bit redundant (both in terms of extra checks needed to avoid mixing targets and in extra typing for the users).
| ### `otk.external.osbuild.depsolve-dnf5` | ||
|
|
||
| Expects a `map` as its value. | ||
| ### `otk.external.osbuild.file-from-text` |
There was a problem hiding this comment.
(nitpick) neither this nor the one below are actually used yet, I think would be ideal if all our directives have a use-case
There was a problem hiding this comment.
Right; but removing them today only to re-add them next week when the usecase arises (for these directives: it will, they're necessary for the file customization(s) and a few image types) also seems a bit weird.
|
This is obsolete with the most recent discussions |
The depsolve-dnf5 description was mixed up with the description below. This commit fixes this.